Skip to content

Conversation

@jmgilman
Copy link
Collaborator

@jmgilman jmgilman commented Jan 3, 2026

Motivation

  • Default the runtime to Docker to match new integration test coverage and CI expectations.
  • Reflect expanded platform support (macOS and Linux) across docs and ADRs now that Linux runtimes are supported.
  • Ensure runtime defaults and manager fallbacks are consistent with the new cross-platform posture.

Description

  • Changed the default runtime in the configuration loader from podman to docker (internal/config/config.go).
  • Updated manager fallback to use RuntimeDocker when no runtime is specified and clarified the ManagerConfig comment (internal/instance/manager.go).
  • Updated CLI/runtime selection defaults to prefer Docker and adjusted the runtime binary mapping in internal/cmd/root.go.
  • Revised documentation and ADRs to indicate macOS and Linux support and to make Docker the documented default, including README.md, docs/*, and docs/reference/configuration.md examples, and updated the manager unit test expectation in internal/instance/manager_test.go.

Testing

  • Updated unit test TestNewManager to expect RuntimeDocker as the default; the test file was adjusted accordingly.
  • No automated test suite (unit or integration) was run as part of this change.
  • Integration test harness and scripts were left intact and continue to support docker, podman, and apple runtimes for CI use.

Codex Task

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
headjack 3234e76 Commit Preview URL

Branch Preview URL
Jan 03 2026, 08:13 PM

@jmgilman jmgilman merged commit b273678 into master Jan 3, 2026
4 checks passed
@jmgilman jmgilman deleted the codex/set-docker-as-default-runtime-and-update-docs branch January 3, 2026 20:18
jmgilman added a commit that referenced this pull request Jan 3, 2026
…oss-platform support

Current behavior:
Podman was the default container runtime and documentation focused primarily on macOS support

New behavior:
Docker is now the default runtime with updated documentation reflecting support for both macOS and Linux platforms, including cross-platform keyring storage and runtime configuration guidance

Closes: #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants