Skip to content

Store challenge-checks on user-data #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2020
Merged

Store challenge-checks on user-data #119

merged 4 commits into from
Oct 29, 2020

Conversation

@jotoeri
Copy link
Member

@jotoeri jotoeri commented Oct 21, 2020 •
edited
Loading

  • Move check-translation to DOM-Insert
  • Store and Reload checks
  • Allow i18n-parser to recognize calls to addToVerifyList

Fix #101

@jotoeri jotoeri added enhancement New feature or request user-interface Concerns UI and usability of the App labels Oct 21, 2020
@jotoeri jotoeri added this to the 5.1 milestone Oct 21, 2020
@jotoeri jotoeri force-pushed the enh/store_checks branch 2 times, most recently from 825a24e to dfc8b5c Compare October 26, 2020 20:00
@jotoeri
Move verify translation to front end
cdae5d1 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Include verify in user-data, rename completed in json
a071de2 
User-data now stores the same structure as verify returns.

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Store and reload verify-result
1f682ca 
Automatically leads to translations, as the page reloads completely on language-change.

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Make i18n-parser read the new way of inserting verify-messages
214bb2a 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri marked this pull request as ready for review October 29, 2020 18:37
@jotoeri jotoeri merged commit 09d4ca4 into main Oct 29, 2020
@jotoeri jotoeri deleted the enh/store_checks branch October 29, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@966556296635 966556296635 966556296635 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request user-interface Concerns UI and usability of the App

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

Store challengeChecks in userData

2 participants

@jotoeri @966556296635