Fix rtl languages #152
Merged
Fix rtl languages #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotoeri
added
enhancement
jotoeri
force-pushed
the
fix/rtl_languages
branch
from
bc9e4b8 to
b6d99dc
Compare
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com> Co-authored-by: Akam Foad <akamfoad@users.noreply.github.com>
jotoeri
force-pushed
the
fix/rtl_languages
branch
from
b558b7d to
7bb3eed
Compare
Co-authored-by: Akam Foad <akamfoad@users.noreply.github.com> Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
force-pushed
the
fix/rtl_languages
branch
from
f8cc5e9 to
6e8b232
Compare
|
Hm, should be good to go, i think. Anything you miss, @akamfoad? (Except index-page naturally, but that has different origin, so will be a followup-PR...) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support rtl-languages:
direction: rtldefined within appLanguages-Object-> PR currently breaks index-page, this needs to be done separately, to include the index-page into the templates.
@akamfoad Can you have a look on here? Does this look properly? The right-align of code-elements seems proper to me, but is this typical usage for such texts in rtl? -> Currently only visible on first challenge, i'll now start to insert the divs on other challenges...