Skip to content

2.0.5: default mkvmerge_path regression #12

@owenthewizard

Description

@owenthewizard

Describe the bug
MKVFile without specifying mkvmerge_path seems broken in 2.0.5.

To Reproduce
mkv = MKVFile(title=f'my_title')

Expected behavior
No error.

Screenshots

Traceback (most recent call last):
  File "C:\my_script.py", line 131, in <module>
    mkv = MKVFile(title=f'my_title')
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\me\AppData\Roaming\Python\Python312\site-packages\pymkv\MKVFile.py", line 111, in __init__
    if not verify_supported(file_path, mkvmerge_path=self.mkvmerge_path):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\me\AppData\Roaming\Python\Python312\site-packages\pymkv\Verifications.py", line 187, in verify_supported
    file_path = verify_file_path_and_mkvmerge(file_path, mkvmerge_path)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\me\AppData\Roaming\Python\Python312\site-packages\pymkv\Verifications.py", line 135, in verify_file_path_and_mkvmerge
    return checking_file_path(file_path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\me\AppData\Roaming\Python\Python312\site-packages\pymkv\Verifications.py", line 33, in checking_file_path
    raise TypeError(msg)
TypeError: "None" is not of type str

Software (please complete the following information):

  • OS: Windows 11 23H2
  • MKVToolNix version v85.0

Additional context
Does not occur in 2.0.4

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions