Updated type verification and enhanced file validation #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded the type check for 'mkvmerge_path' to now include list, os.PathLike, and None aside from string. Improved the interface of the 'file_path' setter of the MKVTrack to better handle unsupported files. Added a verification step when initializing an MKVFile to ensure that the file is a supported Matroska file. Updated the 'MKVFile' class and unit tests to reflect these changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 49.12% 50.46% +1.33%
==========================================
Files 10 10
Lines 861 864 +3
==========================================
+ Hits 423 436 +13
+ Misses 438 428 -10 ☔ View full report in Codecov by Sentry. |
A new test file, 'test_verify.py', has been added to test the 'verify_matroska' function of the MKVFile and MKVTrack classes. The unit tests assert whether the function results are correct when provided with valid and invalid input parameters. The 'test_open_files.py' file has also been updated to include additional test scenarios for these classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded the type check for 'mkvmerge_path' to now include list, os.PathLike, and None aside from string. Improved the interface of the 'file_path' setter of the MKVTrack to better handle unsupported files. Added a verification step when initializing an MKVFile to ensure that the file is a supported Matroska file. Updated the 'MKVFile' class and unit tests to reflect these changes.