Test mkv file #15
Merged
Test mkv file #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces multiple test cases in test_actions_track.py which cover muxing functionality, track handling, and handling of title in MKV files. Each introduced test function validates a specific boundary case or functionality and asserts the expected behavior.
This commit introduces new unit tests within the test_add_file.py script. The tests validate that the file_id and track_id are correctly attributed within the MKV tracks. The file ID is expected to change every two tracks, while the track ID should alternate between 0 and 1.
A new assert condition has been added to the test_open_file function to check if the mkv.title is None. Moreover, a new test case, test_verify_mkvmerge_in_mkv_file, has been introduced to verify the mkvmerge path and raise a FileNotFoundError if the path is incorrect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
===========================================
+ Coverage 50.46% 64.81% +14.35%
===========================================
Files 10 10
Lines 864 864
===========================================
+ Hits 436 560 +124
+ Misses 428 304 -124 ☔ View full report in Codecov by Sentry. |
This update introduces additional tests for the 'get_track' function in the 'test_actions_track.py' file. It specifically addresses two new scenarios: when the function retrieves a specific track and when the function raises an error due to an invalid track number. The type hint for the 'get_track' function in the 'MKVFile.py' file has also been updated to reflect that it can return a list of tracks.
This update introduces comprehensive tests in 'test_timestamp.py' for the 'Timestamp' class in the 'pymkv' module. The code also refactors the usage of regular expressions in 'Timestamp.py', replacing direct 'match' calls with 're.match' and refining the 'verify' method to exclusively handle string inputs.
New unit tests for the MKVAttachment class have been added in `tests/test_mkv_attachment.py` to increase overall test coverage. Additionally, added a pytest fixture in `tests/conftest.py` for a temporary text file used in tests. Clean-up routines have also been updated to account for the creation of temporary `.txt` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.