Skip to content

Conversation

owenthewizard
Copy link

No description provided.

@GitBib
Copy link
Owner

GitBib commented Oct 13, 2024

Probably better to make this change in bcp47 by re-downloading the PDF and suggesting these tweaks to bcp47.py, 'cause it'll be a pain to maintain and manage otherwise.

@owenthewizard
Copy link
Author

Probably better to make this change in bcp47 by re-downloading the PDF and suggesting these tweaks to bcp47.py, 'cause it'll be a pain to maintain and manage otherwise.

Are und mal and zaa in the BCP47 spec? I thought they were specific to MKV.

@GitBib
Copy link
Owner

GitBib commented Oct 14, 2024

und means undetermined, but I don't know anything about mal or zaa. Any chance you could send a link with info on those two?

@GitBib
Copy link
Owner

GitBib commented Oct 14, 2024

Found 'mal' and 'zaa' in mkvmerge --list-languages. Maybe we can build on this? So pymkv can check mkvmerge's language list by itself.

@owenthewizard
Copy link
Author

mkvmerge --list-languages only lists ISO, not BCP47. But we could check both. What do you think?

@owenthewizard
Copy link
Author

Imo we shouldn't do any verification, just leave it up to the user and let mkvmerge throw an error.

@GitBib
Copy link
Owner

GitBib commented Nov 17, 2024

In PR #39 and #38, I disabled the BCP47 check.

@GitBib GitBib closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants