Skip to content

Conversation

rcolfin
Copy link
Contributor

@rcolfin rcolfin commented Nov 18, 2024

This PR is a continuation of #25

Enabling builds on macos, windows and ubuntu against python versions: 3.9, 3.10, 3.11, 3.12 and 3.13.

@rcolfin rcolfin changed the title Add matrix strategy to GitHub Actions workflow, enabling builds on Add matrix strategy to GitHub Actions workflow Nov 18, 2024
@GitBib
Copy link
Owner

GitBib commented Dec 1, 2024

For proper functionality, the path to mkvmerge needs to be passed in all tests, as the command differs between Windows and Linux.

@rcolfin
Copy link
Contributor Author

rcolfin commented Dec 1, 2024

For proper functionality, the path to mkvmerge needs to be passed in all tests, as the command differs between Windows and Linux.

Isn't it? I had tried it before on my repo and I had all the tests passing...

@rcolfin
Copy link
Contributor Author

rcolfin commented Dec 1, 2024

Can you enable all the checks?

macos, windows and ubuntu against python versions: 3.9, 3.10, 3.11, 3.12
and 3.13.

(Continuation of GitBib#25)
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.84%. Comparing base (bdca1fe) to head (89d4ecf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pymkv/Verifications.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   66.73%   66.84%   +0.10%     
==========================================
  Files          10       10              
  Lines         947      947              
==========================================
+ Hits          632      633       +1     
+ Misses        315      314       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcolfin
Copy link
Contributor Author

rcolfin commented Dec 1, 2024

Can you enable all the checks?

@GitBib Does it look ok to merge now?

@GitBib GitBib merged commit d0ef1cd into GitBib:master Dec 1, 2024
18 checks passed
@rcolfin rcolfin deleted the fix_matrix_tests branch December 1, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants