Add test for MKV creation and streamline MKVTrack behavior #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new unit test `test_create_new_mkv` for validating MKV file creation with a subtitle track. Update the `MKVTrack` class to safely handle track ID setting by directly ensuring `_info_json` availability, and adjust file cleanup utility to handle SRT files in tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 65.98% 66.34% +0.35%
==========================================
Files 10 10
Lines 932 933 +1
==========================================
+ Hits 615 619 +4
+ Misses 317 314 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new unit test
test_create_new_mkvfor validating MKV file creation with a subtitle track. Update theMKVTrackclass to safely handle track ID setting by directly ensuring_info_jsonavailability, and adjust file cleanup utility to handle SRT files in tests.