perf: optimize MKV file loading performance by reducing redundant mkv… #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merge calls This commit implements several performance optimizations to significantly reduce the number of mkvmerge subprocess calls when loading MKV files. Key changes: - Cache verify_mkvmerge() results using @cache decorator to avoid repeated mkvmerge -V calls across multiple file loads - Remove redundant verify_supported() call from MKVFile.__init__ before get_file_info(), checking container["supported"] from JSON response instead - Skip verify_supported() in MKVTrack.file_path setter when existing_info is already provided (tracks from existing MKV don't need revalidation) - Add pyinstrument profiling support for tests with per-test HTML reports Performance improvement: - Before: ~10 seconds to load 10 files - After: ~0.4 seconds to load 10 files - Speedup: ~25x faster Addresses performance issues raised in #16 by eliminating duplicate mkvmerge invocations while maintaining file validation integrity.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 66.87% 67.01% +0.13%
==========================================
Files 10 10
Lines 951 958 +7
==========================================
+ Hits 636 642 +6
- Misses 315 316 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use regex pattern to support both Unix (/) and Windows (\) path separators in test_file_not_support and test_track_not_support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements several performance optimizations to significantly reduce the number of mkvmerge subprocess calls when loading MKV files.
Key changes:
Performance improvement:
Addresses performance issues raised in #16 by eliminating duplicate mkvmerge invocations while maintaining file validation integrity.