Add support for OAuth with GitHub AE #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for detecting GitHub AE (GHAE) and enabling the OAuth authentication mode with the GitHub provider. https://docs.github.com/en/github-ae@latest/admin/overview/about-github-ae
mjcheetham
requested review from
derrickstolee,
dscho,
jeffhostetler,
ldennington,
prplr and
vtbassmatt
mjcheetham
commented
May 12, 2021
| /// Minimum GitHub Enterprise version that supports OAuth authentication with GCM Core. | ||
| /// </summary> | ||
| // TODO: update this with a real version number once the GCM OAuth application has been deployed to GHE | ||
| public static readonly Version MinimumEnterpriseOAuthVersion = new Version("99.99.99"); |
Contributor
Author
There was a problem hiding this comment.
Once we know which version of GHES has the OAuth app deployed, we can update this constant too.
Contributor
There was a problem hiding this comment.
Will this ever cause confusion since "Enterprise" is a part of the name of three different GitHub products? MinimumOnPremOAuthVersion maybe? (This may be pointless bikeshedding on my part - the question is genuine but not particularly important.)
Contributor
Author
There was a problem hiding this comment.
Feel free to submit the rename PR to that OnPrem suggestion ;)
Contributor
There was a problem hiding this comment.
Whoops, can't resolve, since you had left this as a note to yourself.
mjcheetham
added
enhancement
derrickstolee
approved these changes
May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for detecting GitHub AE (GHAE) and enabling the OAuth authentication mode with the GitHub provider.
We assume that all instances of GHAE have the GCM OAuth application deployed.
https://docs.github.com/en/github-ae@latest/admin/overview/about-github-ae