Skip to content

fix: init model_keys to prevent error on task flows without model config #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix: init model_keys to prevent error on task flows without model config #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ async def on_handoff_hook(
# optional global vars available for the taskflow tasks
global_variables = taskflow.get('globals', {})
model_config = taskflow.get('model_config', {})
model_keys = []
if model_config:
model_dict = available_tools.model_config.get(model_config, {})
if not model_dict:
Comment on lines +433 to 436
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While initializing model_keys = [] prevents the UnboundLocalError, the code after line 436 likely assigns a value to model_keys from model_dict. Without seeing the complete conditional block, verify that the code correctly handles the case where model_keys remains an empty list when model_config is absent or invalid, as downstream code may expect model_keys to contain specific values.

Copilot uses AI. Check for mistakes.
Expand Down