Skip to content

Try passing the environment as a JSON string #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Try passing the environment as a JSON string #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/publish-to-testpypi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ on:
jobs:
publish:
name: Publish wheel to TestPyPI
runs-on: ubuntu-latest
environment:
name: testpypi
url: https://test.pypi.org/p/seclab-taskflow-agent2
permissions:
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runs-on key is required for all jobs that don't call reusable workflows with uses. Since this job calls a reusable workflow, the runs-on should not be defined here (it's defined in the reusable workflow). However, the environment configuration that was removed should be restored at this job level, as it cannot be passed as a parameter to control deployment environments properly.

Copilot uses AI. Check for mistakes.
contents: write
id-token: write # For trusted publishing
Expand All @@ -22,6 +18,6 @@ jobs:
version: ${{ inputs.version }}
release_notes: ${{ github.head_ref }}
repository_url: https://test.pypi.org/legacy/
environment: testpypi
environment: '{"name": "testpypi", "url": "https://test.pypi.org/p/seclab-taskflow-agent2"}'
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable workflow expects an input parameter named environment_name (not environment), and it should be a simple string value like 'testpypi', not a JSON object. The environment configuration with name and URL should be defined at the job level in this workflow, not passed as a parameter. Change this line to environment_name: testpypi and restore the job-level configuration that was removed.

Suggested change
environment: '{"name": "testpypi", "url": "https://test.pypi.org/p/seclab-taskflow-agent2"}'
environment_name: testpypi
environment:
name: testpypi
url: https://test.pypi.org/p/seclab-taskflow-agent2

Copilot uses AI. Check for mistakes.
secrets:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}