Skip to content

Update help message example to -p personalities.assistant #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update help message example to -p personalities.assistant #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/seclab_taskflow_agent/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def parse_prompt_args(available_tools: AvailableTools,
#parser.add_argument('remainder', nargs=argparse.REMAINDER, help="Remaining args")
help_msg = parser.format_help()
help_msg += "\nExamples:\n\n"
help_msg += "`-p assistant explain modems to me please`\n"
help_msg += "`-p personalities.assistant explain modems to me please`\n"
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example help message uses an incomplete personality reference. Based on the codebase, the correct format should be seclab_taskflow_agent.personalities.assistant (the full package path), not just personalities.assistant.

This is evident from:

  1. The README.md (line 71) which shows: hatch run main -p seclab_taskflow_agent.personalities.assistant 'explain modems to me please'
  2. The documentation (README.md lines 487-491) which explains that names like seclab_taskflow_agent.personalities.assistant get split at the last . into package name and filename
  3. The actual implementation in available_tools.py (line 59-61) which splits on . and expects format "packagename.filename"
  4. All taskflow YAML files throughout the codebase use the full format seclab_taskflow_agent.personalities.assistant

The help message should use the same format to be consistent with actual usage.

Suggested change
help_msg += "`-p personalities.assistant explain modems to me please`\n"
help_msg += "`-p seclab_taskflow_agent.personalities.assistant explain modems to me please`\n"

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@kevinbackhouse kevinbackhouse Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @copilot. If you install with pip install seclab_taskflow_agent, then the correct name for the assistant is seclab_taskflow_agent.personalities.assistant.

Copy link
Contributor Author

@sylwia-budzynska sylwia-budzynska Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running the docker container with the script, the way to run it would be with -p personalities.assistant explain modems to me please. We could consider unifying this and/or updating the docker docs too.

try:
args = parser.parse_known_args(user_prompt.split(' ') if user_prompt else None)
except SystemExit as e:
Expand Down
Loading