Move to V4 API.

[fbourigault]

Gitlab V3 api will be removed in 9.5 release (22th august).

From https://docs.gitlab.com/ce/api/v3_to_v4.html, I listed all breaking changes in the API. All those changes does not affect us but we have to double check!!!

So if anyone could look into the code and tell if we are affected or not, I would be happy to tick boxes. If we are affected, feel free to open PRs to fix it.

cc @m1guelpf

8.17

• Removed GET /projects/:search (use: GET /projects?search=x) !8877
• iid filter has been removed from GET /projects/:id/issues !8967
• GET /projects/:id/merge_requests?iid[]=x&iid[]=y array filter has been renamed to iids !8793
• Endpoints under GET /projects/merge_request/:id have been removed (use: GET /projects/merge_requests/:id) !8793
• Project snippets do not return deprecated field expires_at !8723
• Endpoints under GET /projects/:id/keys have been removed (use GET /projects/:id/deploy_keys) !8716

9.0

• Status 409 returned for POST /projects/:id/members when a member already exists !9093
• Moved DELETE /projects/:id/star to POST /projects/:id/unstar !9328
• Removed the following deprecated Templates endpoints (these are still accessible with /templates prefix) !8853
  • /licences
  • /licences/:key
  • /gitignores
  • /gitlab_ci_ymls
  • /dockerfiles
  • /gitignores/:key
  • /gitlab_ci_ymls/:key
  • /dockerfiles/:key
• Moved POST /projects/fork/:id to POST /projects/:id/fork !8940
• Moved DELETE /todos to POST /todos/mark_as_done and DELETE /todos/:todo_id to POST /todos/:todo_id/mark_as_done !9410
• Project filters are no longer available as GET /projects/foo, but as GET /projects?foo=true instead !8962
  • GET /projects/visible & GET /projects/all are consolidated into GET /projects and can be used with or without authorization
  • GET /projects/owned moved to GET /projects?owned=true
  • GET /projects/starred moved to GET /projects?starred=true
• GET /projects returns all projects visible to current user, even if the user is not a member !9674
  • To get projects the user is a member of, use GET /projects?membership=true
• Return pagination headers for all endpoints that return an array !8606
• Added POST /environments/:environment_id/stop to stop an environment !8808
• Removed DELETE /projects/:id/deploy_keys/:key_id/disable. Use DELETE /projects/:id/deploy_keys/:key_id instead !9366
• Moved PUT /users/:id/(block|unblock) to POST /users/:id/(block|unblock) !9371
• Make subscription API more RESTful. Use POST /projects/:id/:subscribable_type/:subscribable_id/subscribe to subscribe and POST /projects/:id/:subscribable_type/:subscribable_id/unsubscribe to unsubscribe from a resource. !9325
• Labels filter on GET /projects/:id/issues and GET /issues now matches only issues containing all labels (i.e.: Logical AND, not OR) !8849
• Renamed param branch_name to branch on the following endpoints !8936
  • POST /projects/:id/repository/branches
  • POST /projects/:id/repository/commits
  • POST/PUT/DELETE :id/repository/files
• Renamed the merge_when_build_succeeds parameter to merge_when_pipeline_succeeds on the following endpoints: !9335
  • PUT /projects/:id/merge_requests/:merge_request_id/merge
  • POST /projects/:id/merge_requests/:merge_request_id/cancel_merge_when_pipeline_succeeds
  • POST /projects
  • POST /projects/user/:user_id
  • PUT /projects/:id
• Renamed branch_name to branch on DELETE /projects/:id/repository/branches/:branch response !8936
• Remove public param from create and edit actions of projects !8736
• Remove subscribed field from responses returning list of issues or merge
  requests. Fetch individual issues or merge requests to obtain the value
  of subscribed
  !9661
• Use visibility as string parameter everywhere !9337
• Notes do not return deprecated field upvote and downvote !9384
• Return HTTP status code 400 for all validation errors when creating or updating a member instead of sometimes 422 error. !9523
• Remove GET /groups/owned. Use GET /groups?owned=true instead !9505
• Return 202 with JSON body on async removals on V4 API (DELETE /projects/:id/repository/merged_branches and DELETE /projects/:id) !9449
• GET /projects/:id/milestones?iid[]=x&iid[]=y array filter has been renamed to iids !9096
• Return basic info about pipeline in GET /projects/:id/pipelines !8875
• Renamed all build references to job !9463
• Drop GET /projects/:id/repository/commits/:sha/jobs !9463
• Rename Build Triggers to be Pipeline Triggers API !9713
  • POST /projects/:id/trigger/builds to POST /projects/:id/trigger/pipeline
  • Require description when creating a new trigger POST /projects/:id/triggers
• Simplify project payload exposed on Environment endpoints !9675
• API uses merge request IIDs (internal ID, as in the web UI) rather than IDs. This affects the merge requests, award emoji, todos, and time tracking APIs. !9530
• API uses issue IIDs (internal ID, as in the web UI) rather than IDs. This affects the issues, award emoji, todos, and time tracking APIs. !9530
• Change initial page from 0 to 1 on GET /projects/:id/repository/commits (like on the rest of the API) !9679
• Return correct Link header data for GET /projects/:id/repository/commits !9679
• Update endpoints for repository files !9637
  • Moved GET /projects/:id/repository/files?file_path=:file_path to GET /projects/:id/repository/files/:file_path (:file_path should be URL-encoded)
  • GET /projects/:id/repository/blobs/:sha now returns JSON attributes for the blob identified by :sha, instead of finding the commit identified by :sha and returning the raw content of the blob in that commit identified by the required ?filepath=:filepath
  • Moved GET /projects/:id/repository/commits/:sha/blob?file_path=:file_path and GET /projects/:id/repository/blobs/:sha?file_path=:file_path to GET /projects/:id/repository/files/:file_path/raw?ref=:sha
  • GET /projects/:id/repository/tree parameter ref_name has been renamed to ref for consistency
• confirm parameter for POST /users has been deprecated in favor of skip_confirmation parameter

[m4tthumphrey]

Wow! Thank you so much for taking this on! 🙇

[fbourigault]

As this list may be hard to user, I think we should do a PR per gitlab merge request which introduced the change.

You can find changes for !8936 in #205.

[fbourigault]

We are not affected by !9328, !8853, !8808, !9335, !9713, !9505, !9325, !9661, !9675, !9410, !8849, !8736, !9096, !9384, !9523, !9449, !8875, !9093 and !9410 changes.

You can find changes for !8940 in #206, for !8716 and !9366 in #210, for !8723 in #211, for !9679 in #215, for !9637 in #214, for !8967 in #216, for !9530 in #217, for !9337 in #218, for !8793 in #221, for !9463 in #222 and for !9371 in #207.

[fbourigault]

I'm working on changes affecting the GET /projects endpoint. Do we agree using the Symfony OptionsResolver component to handle nicely all available options?

This will enable strong input validation and will help to keep code clean (i.e. avoid code like this).

[m1guelpf]

@fbourigault 👍

[fbourigault]

You can have a look of how the code is when using OptionsResolver: master...fbourigault:options-resolver

[m1guelpf]

@fbourigault Cleaner. I like it.

[fbourigault]

Some people suggested me to not using the $definition array as it looks like a code offuscation. I updated the diff and it looks better to me.

[fbourigault]

You can find changes for for !8962, !8877 and !9674 in #213.

[fbourigault]

Everything have been merged.

I will release a beta by the end of this week. From 5th to 12th, I will be offline.
Then I hope enough people will have test this first beta and if there are regressions, a 2nd beta could be released around the 17th. Then I plan to release a RC around the 21th and a stable by the end of the month.

Because of the really short delay until https://gitlab.com v3 API get shutdown, I think this is fair compromise!