Skip to content

add bad code #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add bad code #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
#include <iostream>
#include <cstring>
#include <vector>

using namespace std;

int divide(int divisor) {
int dividend;
return dividend / divisor;
}
Comment on lines +7 to +10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix uninitialized variable and add division by zero check.

The function has two critical issues:

  1. dividend is used without initialization, causing undefined behavior
  2. No check for division by zero, which will crash when called with divisor = 0

Apply this fix:

-int divide(int divisor) {
-    int dividend;
-    return dividend / divisor;
-}
+int divide(int dividend, int divisor) {
+    if (divisor == 0) {
+        throw std::invalid_argument("Division by zero");
+    }
+    return dividend / divisor;
+}

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In main.cpp around lines 7 to 10, the variable dividend is used without
initialization, leading to undefined behavior, and there is no check for
division by zero which can cause a crash. Initialize dividend with a valid value
before using it and add a condition to check if divisor is zero; if so, handle
the error appropriately (e.g., return an error code or throw an exception) to
prevent division by zero.


void copyString() {
char buffer[10];
strcpy(buffer, "This string is way too long!");
cout << buffer << endl;
}
Comment on lines +12 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical buffer overflow vulnerability.

The string being copied exceeds the buffer size, causing a buffer overflow. This is a serious security vulnerability.

Use safer string handling:

-void copyString() {
-    char buffer[10];
-    strcpy(buffer, "This string is way too long!");
-    cout << buffer << endl;
-}
+void copyString() {
+    const char* message = "This string is way too long!";
+    char buffer[50]; // Ensure buffer is large enough
+    strncpy(buffer, message, sizeof(buffer) - 1);
+    buffer[sizeof(buffer) - 1] = '\0'; // Ensure null termination
+    cout << buffer << endl;
+}
🤖 Prompt for AI Agents 
In main.cpp around lines 12 to 16, the function copyString uses strcpy to copy a
string that exceeds the size of the buffer, causing a buffer overflow. Replace
strcpy with a safer alternative like strncpy or use std::string to avoid
overflow. Ensure the copied string fits within the buffer size and is
null-terminated to prevent security issues.


void createPointer() {
int* ptr = new int[100];
}
Comment on lines +18 to +20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Memory leak: allocated memory is never freed.

The function allocates memory but never deallocates it, causing a memory leak.

Either deallocate the memory or return the pointer:

-void createPointer() {
-    int* ptr = new int[100];
-}
+void createPointer() {
+    int* ptr = new int[100];
+    // Use the pointer...
+    delete[] ptr; // Don't forget to deallocate
+}

Or better, use smart pointers:

void createPointer() {
    auto ptr = std::make_unique<int[]>(100);
    // Memory automatically freed when ptr goes out of scope
}
🤖 Prompt for AI Agents 
In main.cpp around lines 18 to 20, the function createPointer allocates memory
with new but never frees it, causing a memory leak. Fix this by either deleting
the allocated memory with delete[] before the function ends or, preferably,
replace the raw pointer with a smart pointer like std::unique_ptr using
std::make_unique<int[]>(100) so the memory is automatically managed and freed
when the pointer goes out of scope.


void deletePointer() {
int* data = new int(42);
delete data;
cout << *data << endl;
}
Comment on lines +22 to +26
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Use-after-free bug: dereferencing deleted pointer.

The function dereferences a pointer after deleting it, causing undefined behavior.

Access the value before deletion:

-void deletePointer() {
-    int* data = new int(42);
-    delete data;
-    cout << *data << endl;
-}
+void deletePointer() {
+    int* data = new int(42);
+    cout << *data << endl; // Access before delete
+    delete data;
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void deletePointer() {
int* data = new int(42);
delete data;
cout << *data << endl;
}
void deletePointer() {
int* data = new int(42);
cout << *data << endl; // Access before delete
delete data;
}
🤖 Prompt for AI Agents 
In main.cpp around lines 22 to 26, the function dereferences a pointer after it
has been deleted, causing a use-after-free bug. To fix this, access or print the
value pointed to by the pointer before calling delete, and remove any
dereferencing after the delete statement.


bool isPositive(int num) {
if (num > 0)
return true;
else if (num <= 0)
return false;
return false;
}
Comment on lines +28 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Simplify redundant conditions.

The function has redundant conditions and unreachable code.

Simplify to:

-bool isPositive(int num) {
-    if (num > 0)
-        return true;
-    else if (num <= 0)
-        return false;
-    return false;
-}
+bool isPositive(int num) {
+    return num > 0;
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
bool isPositive(int num) {
if (num > 0)
return true;
else if (num <= 0)
return false;
return false;
}
bool isPositive(int num) {
return num > 0;
}
🤖 Prompt for AI Agents 
In main.cpp around lines 28 to 34, the function isPositive contains redundant
conditions and unreachable code. Simplify the function by removing the else if
and the final return statement, directly returning the result of the condition
(num > 0).


void castType() {
double d = 3.1415926535;
int* pi = (int*)&d;
cout << *pi << endl;
}
Comment on lines +36 to +40
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Type punning violates strict aliasing rules.

Casting a double pointer to an int pointer and dereferencing it is undefined behavior.

Use proper type conversion or union:

-void castType() {
-    double d = 3.1415926535;
-    int* pi = (int*)&d;
-    cout << *pi << endl;
-}
+void castType() {
+    double d = 3.1415926535;
+    int i = static_cast<int>(d); // Proper conversion
+    cout << i << endl;
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void castType() {
double d = 3.1415926535;
int* pi = (int*)&d;
cout << *pi << endl;
}
void castType() {
double d = 3.1415926535;
int i = static_cast<int>(d); // Proper conversion
cout << i << endl;
}
🤖 Prompt for AI Agents 
In main.cpp around lines 36 to 40, the code casts a double pointer to an int
pointer and dereferences it, which violates strict aliasing rules and causes
undefined behavior. To fix this, replace the pointer cast with a safer method
such as using a union to access the double's bytes as an int or use memcpy to
copy the double's bytes into an int variable. Avoid direct pointer casting and
dereferencing between incompatible types.


int string2int(const char* str) {
return atoi(str)
}
Comment on lines +42 to +44
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix syntax error and improve string conversion.

Missing semicolon and using deprecated atoi without proper header inclusion.

Fix syntax and use modern C++ conversion:

+#include <cstdlib> // for atoi
+
-int string2int(const char* str) {
-    return atoi(str)
-}
+int string2int(const char* str) {
+    return std::atoi(str); // Add semicolon and std::
+}

Better yet, use std::stoi for error handling:

#include <string>
int string2int(const std::string& str) {
    try {
        return std::stoi(str);
    } catch (const std::exception& e) {
        // Handle error
        return 0;
    }
}
🤖 Prompt for AI Agents 
In main.cpp around lines 42 to 44, fix the missing semicolon after the return
statement and replace the deprecated atoi function with std::stoi for safer
string to integer conversion. Change the function to accept a const std::string&
parameter, include the <string> header, and add a try-catch block to handle
conversion exceptions, returning 0 on error.


void readArray() {
int arr[5] = {1, 2, 3, 4, 5};
for (int i = 0; i <= 5; i++) {
cout << arr[i] << endl;
}
}
Comment on lines +46 to +51
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Array index out of bounds.

The loop accesses index 5, but the array only has indices 0-4.

Fix the loop condition:

-void readArray() {
-    int arr[5] = {1, 2, 3, 4, 5};
-    for (int i = 0; i <= 5; i++) {
-        cout << arr[i] << endl;
-    }
-}
+void readArray() {
+    int arr[5] = {1, 2, 3, 4, 5};
+    for (int i = 0; i < 5; i++) { // Use < instead of <=
+        cout << arr[i] << endl;
+    }
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void readArray() {
int arr[5] = {1, 2, 3, 4, 5};
for (int i = 0; i <= 5; i++) {
cout << arr[i] << endl;
}
}
void readArray() {
int arr[5] = {1, 2, 3, 4, 5};
for (int i = 0; i < 5; i++) { // Use < instead of <=
cout << arr[i] << endl;
}
}
🤖 Prompt for AI Agents 
In main.cpp around lines 46 to 51, the for loop condition uses i <= 5, which
causes an out-of-bounds access on the array of size 5. Change the loop condition
to i < 5 to ensure the index stays within valid bounds 0 to 4.


void printPointer(int* ptr) {
cout << *ptr << endl;
}
Comment on lines +53 to +55
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add null pointer check.

The function dereferences the pointer without checking for null, causing a crash when called with nullptr.

Add null check:

-void printPointer(int* ptr) {
-    cout << *ptr << endl;
-}
+void printPointer(int* ptr) {
+    if (ptr != nullptr) {
+        cout << *ptr << endl;
+    } else {
+        cout << "Null pointer!" << endl;
+    }
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void printPointer(int* ptr) {
cout << *ptr << endl;
}
void printPointer(int* ptr) {
if (ptr != nullptr) {
cout << *ptr << endl;
} else {
cout << "Null pointer!" << endl;
}
}
🤖 Prompt for AI Agents 
In main.cpp around lines 53 to 55, the function printPointer dereferences the
pointer without checking if it is null, which can cause a crash. Add a null
pointer check at the start of the function to verify if ptr is not null before
dereferencing it. If ptr is null, handle it gracefully, for example by printing
an error message or returning early.


void loopOutputs() {
for (unsigned int i = 10; i >= 0; i--) {
cout << i << endl;
}
}
Comment on lines +57 to +61
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Infinite loop due to unsigned integer wraparound.

An unsigned int is always >= 0. When i reaches 0 and decrements, it wraps to UINT_MAX.

Use signed int or change loop logic:

-void loopOutputs() {
-    for (unsigned int i = 10; i >= 0; i--) {
-        cout << i << endl;
-    }
-}
+void loopOutputs() {
+    for (int i = 10; i >= 0; i--) { // Use signed int
+        cout << i << endl;
+    }
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void loopOutputs() {
for (unsigned int i = 10; i >= 0; i--) {
cout << i << endl;
}
}
void loopOutputs() {
for (int i = 10; i >= 0; i--) { // Use signed int
cout << i << endl;
}
}
🤖 Prompt for AI Agents 
In main.cpp around lines 57 to 61, the loop uses an unsigned int that causes an
infinite loop due to wraparound when decrementing below zero. Fix this by
changing the loop variable to a signed int or by modifying the loop condition to
avoid unsigned wraparound, such as using a signed int for i or adjusting the
loop to count upwards or use a different termination condition.


void copyString1() {
char* str = (char*)malloc(5);
strcpy(str, "Hello");
free(str);
}
Comment on lines +63 to +67
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Buffer overflow: insufficient memory allocation.

"Hello" requires 6 bytes (including null terminator), but only 5 bytes are allocated.

Allocate sufficient memory:

-void copyString1() {
-    char* str = (char*)malloc(5);
-    strcpy(str, "Hello");
-    free(str);
-}
+void copyString1() {
+    const char* message = "Hello";
+    char* str = (char*)malloc(strlen(message) + 1); // +1 for null terminator
+    if (str != nullptr) {
+        strcpy(str, message);
+        free(str);
+    }
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void copyString1() {
char* str = (char*)malloc(5);
strcpy(str, "Hello");
free(str);
}
void copyString1() {
const char* message = "Hello";
char* str = (char*)malloc(strlen(message) + 1); // +1 for null terminator
if (str != nullptr) {
strcpy(str, message);
free(str);
}
}
🤖 Prompt for AI Agents 
In main.cpp around lines 63 to 67, the function copyString1 allocates only 5
bytes for the string "Hello" but does not account for the null terminator,
causing a buffer overflow. Fix this by allocating 6 bytes instead of 5 using
malloc to ensure space for the null terminator.


int globalCounter = 0;

void incrementCounter() {
globalCounter++;
}

int main() {
divide(0);
copyString();
createPointer();
deletePointer();
cout << isPositive(0) << endl;
castType();
cout << string2int("abc") << endl;
readArray();
printPointer(nullptr);
loopOutputs();
copyString1();

return 0;
}