Fix diag switch #4762
Merged
Fix diag switch #4762
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before fix, order of arguments mattered: - unless /diag is last argument, it is ignored; and the following argument is swalloed silently /diag /l gv.log -> diagnostic switch is ignored, no log file is created /l console /diag -> diagnostic output is emitted to console /l gv.log /diag -> diagnostic output is emitted to log file
|
2 tasks
2 tasks
2 tasks
Contributor
|
Thank you @davidjenni for your contribution! |
Member
|
@davidjenni thanks for taking the time to debug this |
Member
|
Thank you so much for fixing this @davidjenni! Should we perhaps update the documentation for this as well? |
Member
I think he was suggesting that #4539 (comment) |
Member
Indeed!
Yes, please! 😊 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to accept
/diagswitch in any argument position on cmd line, not just the last argument position.Related Issues
Resolves #4763
It also addresses the root cause of #4395 but also improves mitigation for #4539
Motivation and Context
Discovered when debugging issue #4539 (diag flag not working). While this is not the root cause for 4539, without the fix in this PR, possible workarounds for 4539 are more brittle.
How Has This Been Tested?
added unit tests to arg parser suite.
Screenshots (if appropriate):
Checklist: