-
Notifications
You must be signed in to change notification settings - Fork 4k
Don't show toolbar when rendering within GitBook app preview #3635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show toolbar when rendering within GitBook app preview #3635
Conversation
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this only on iframe, if we decide to be able to open the preview in a new tab later it will break.
5928449 to
16bf6b9
Compare
When a preview link for a change-request or revision is opened, we show a toolbar with helpful info and actions. However, we don't want to show this toolbar if the site is rendered in an iframe in the GitBook web-app editor, under the preview tab.
This behaviour likely broke when the 'multi-id' functionality became obsolete with the move to gbo v2.
isPreviewRequestutilExamples
Toolbar no longer shows when previewing in-app:

Toolbar still shows when visiting a change-request or revision preview link:
