Skip to content

Conversation

zenoachtig
Copy link
Contributor

I introduced a layout bug in #3655, this fixes it.

We calculate the trigger's position on the screen and set the dropdown menu to be below that. But because of position: absolute it'll be constrained to the nearest relative parent, which is the site's container. This is not an issue when the viewport is smaller than the max container width, but introduces offset from the trigger on bigger displays.

CleanShot 2025-09-17 at 18 03 34@2x

Setting the position to fixed solves this.

CleanShot 2025-09-17 at 18 03 20@2x

Copy link

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 3c2ef87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 5 changed Sep 17, 2025, 4:56 PM
v2-cloudflare (Inspect) ✅ No changes detected - Sep 17, 2025, 5:01 PM
v2-vercel (Inspect) ✅ No changes detected - Sep 17, 2025, 4:14 PM

@zenoachtig zenoachtig merged commit 2bce127 into main Sep 17, 2025
23 of 24 checks passed
@zenoachtig zenoachtig deleted the fix-section-group-dropdown-offset-on-big-screens branch September 17, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants