Skip to content

Fix API URL we proxy insights events to #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Fix API URL we proxy insights events to #3665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e46d4
Fix API URL we proxy insights events to
SamyPesse Sep 18, 2025
895a253
Changeset
SamyPesse Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-ties-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"gitbook": patch
---

Fix missing geo data in site insights because of incorrect proxying of events.
6 changes: 4 additions & 2 deletions packages/gitbook/src/lib/tracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { headers as nextHeaders } from 'next/headers';
import { GITBOOK_API_URL, GITBOOK_DISABLE_TRACKING } from './env';
import { GITBOOK_API_PUBLIC_URL, GITBOOK_DISABLE_TRACKING } from './env';

/**
* Return true if events should be tracked on the site.
Expand Down Expand Up @@ -36,7 +36,9 @@ export async function serveProxyAnalyticsEvent(req: Request) {
headers: { 'content-type': 'text/plain' },
});
}
const url = new URL(`${GITBOOK_API_URL}/v1/orgs/${org}/sites/${site}/insights/events`);

// We make the request to the public API URL to ensure the request is properly enriched by the router..
const url = new URL(`${GITBOOK_API_PUBLIC_URL}/v1/orgs/${org}/sites/${site}/insights/events`);
return await fetch(url.toString(), {
method: 'POST',
headers: {
Expand Down