Skip to content

Conversation

@nolannbiron
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: 764b564

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/react-openapi Patch
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 1 changed Oct 24, 2025, 1:18 PM
v2-cloudflare (Inspect) 👍 Changes approved 3 changed Oct 24, 2025, 1:21 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Oct 24, 2025, 1:20 PM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for alternative text (alt attributes) to card cover images, improving accessibility for users relying on screen readers. The changes update the image type definitions to include an optional alt property and propagate this property through the component hierarchy.

Key Changes:

  • Extended image source type definitions to include an optional alt property
  • Updated the Image component to accept and apply alt text from multiple sources with fallback logic
  • Enhanced table record card cover processing to extract and pass through alt text values

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/gitbook/src/components/utils/Image.tsx Added alt property to image source types and implemented fallback logic for rendering alt text
packages/gitbook/src/components/DocumentView/Table/utils.ts Updated cover processing to extract and include alt text from image records
packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx Passed alt text values to image sources for record card covers
packages/gitbook/src/components/DocumentView/InlineIcon.tsx Removed obsolete TypeScript error suppression comments
package.json Upgraded @gitbook/api dependency to version 0.146.0
.changeset/proud-kings-know.md Added changeset documentation for the feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nolannbiron nolannbiron requested a review from conico974 October 23, 2025 17:25
@nolannbiron nolannbiron merged commit f9f8011 into main Oct 24, 2025
16 checks passed
@nolannbiron nolannbiron deleted the nolann/add-alt-support-for-cards branch October 24, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants