Skip to content

Support inline icon colors #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

Support inline icon colors #3717

merged 2 commits into from
Oct 10, 2025

Conversation

gregberge
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Oct 10, 2025

RND-8273 Inline icons cannot be colored

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6123c6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gregberge gregberge requested a review from SamyPesse October 10, 2025 11:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

Summary of the deployments:

Version URL Status
Vercel https://gitbook-v2-lqzuwknzf-gitbook.vercel.app ✅
Cloudflare https://c73c2b3a-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site 2v 2c
GitBook https://gitbook-v2-lqzuwknzf-gitbook.vercel.app/url/gitbook.com/docs https://c73c2b3a-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E https://gitbook-v2-lqzuwknzf-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://c73c2b3a-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link

argos-ci bot commented Oct 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ✅ No changes detected - Oct 10, 2025, 12:47 PM
v2-cloudflare (Inspect) 👍 Changes approved 3 changed Oct 10, 2025, 12:51 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Oct 10, 2025, 12:50 PM

SamyPesse
SamyPesse approved these changes Oct 10, 2025
View reviewed changes
@gregberge gregberge merged commit ad4d07d into main Oct 10, 2025
16 checks passed
@gregberge gregberge deleted the greg/rnd-8273-inline-icons-cannot-be-colored branch October 10, 2025 12:51
clairechabas added a commit that referenced this pull request Oct 10, 2025
@clairechabas
Merge branch 'main' into claire/RND-8350-fix-web-frame-height
49d3822 
* main:
  Version Packages (#3651)
  Support inline icon colors (#3717)
  Fix bundling of embed package (#3716)
  Enhance OpenAPI security scopes handling (#3712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamyPesse SamyPesse SamyPesse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregberge @SamyPesse