Skip to content

Conversation

@gregberge
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 21, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: 23fa5e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where clicking on tabs causes an unwanted page jump. The solution prevents unnecessary scrolling by tracking previous hash/pathname values and only scrolling when there are actual changes. Additionally, it prevents Next.js router from auto-scrolling when tabs are clicked.

Key changes:

  • Added a usePrevious hook to track previous values of hash and pathname
  • Modified scroll behavior to only trigger when hash or pathname actually changes
  • Disabled automatic scroll behavior in the Next.js router when replacing tab URLs

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/gitbook/src/components/hooks/usePrevious.ts New hook to track previous render values
packages/gitbook/src/components/hooks/useScrollPage.ts Updated scroll logic to compare previous/current values and avoid unnecessary scrolling
packages/gitbook/src/components/DocumentView/Tabs/DynamicTabs.tsx Disabled router scroll behavior when changing tabs and added scroll-margin to tab panels

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gregberge gregberge requested a review from conico974 October 21, 2025 15:41
@argos-ci
Copy link

argos-ci bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 1 changed Oct 21, 2025, 3:47 PM
v2-cloudflare (Inspect) ✅ No changes detected - Oct 21, 2025, 3:51 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Oct 21, 2025, 3:50 PM

@gregberge gregberge merged commit d436b04 into main Oct 21, 2025
16 checks passed
@gregberge gregberge deleted the greg/rnd-8463-scroll-jumps-when-changing-tab-in-gbo branch October 21, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants