Skip to content

Fix preloading images #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 22, 2025
Merged

Fix preloading images #3747

merged 7 commits into from
Oct 22, 2025

Conversation

@conico974
Copy link
Contributor

@conico974 conico974 commented Oct 22, 2025 •
edited
Loading

Fix preloading images to avoid preloading every image on every route

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc42bf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025 •
edited
Loading

Summary of the deployments:

Version URL Status
Vercel https://gitbook-v2-bkn4y33wy-gitbook.vercel.app ✅
Cloudflare https://0411cd11-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site 2v 2c
GitBook https://gitbook-v2-bkn4y33wy-gitbook.vercel.app/url/gitbook.com/docs https://0411cd11-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E https://gitbook-v2-bkn4y33wy-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://0411cd11-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci
Copy link

argos-ci bot commented Oct 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ✅ No changes detected - Oct 22, 2025, 1:06 PM
v2-cloudflare (Inspect) ✅ No changes detected - Oct 22, 2025, 1:06 PM
v2-vercel (Inspect) ✅ No changes detected - Oct 22, 2025, 1:09 PM

@conico974 conico974 changed the title Add Preloader component for image preloading Fix preloading images Oct 22, 2025
emmerich
emmerich approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock but with a few comments.

@conico974 conico974 merged commit 3164f1a into main Oct 22, 2025
16 checks passed
@conico974 conico974 deleted the conico/img-preload branch October 22, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmerich emmerich emmerich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@conico974 @emmerich