Skip to content

Conversation

@nolannbiron
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2025

⚠️ No Changeset found

Latest commit: 6533cf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for filtering out hidden sections and section groups from the site structure. The changes ensure that sections where all site spaces are hidden are excluded from the visible sections list, improving the user experience by not displaying inaccessible content.

  • Introduced filtering logic to exclude sections with only hidden site spaces
  • Added recursive filtering for section groups to handle nested structures
  • Updated parseSiteSectionsAndGroups to apply the new filtering logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@argos-ci
Copy link

argos-ci bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 2 changed Dec 1, 2025, 1:30 PM
v2-cloudflare (Inspect) 👍 Changes approved 10 changed Dec 1, 2025, 1:35 PM
v2-vercel (Inspect) 👍 Changes approved 10 changed Dec 1, 2025, 1:34 PM

@nolannbiron nolannbiron marked this pull request as ready for review November 27, 2025 15:52
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right place to do that actually ? These sections are hidden in navigation only right ?
The context is used basically everywhere, and I'm wondering if removing stuff from here could actually break other parts like the sitemap for example

@nolannbiron
Copy link
Member Author

nolannbiron commented Nov 27, 2025

@conico974 it's enabled only for one customer and they don't really care about sitemap, it's already working for variants but I'll double check if it breaks anything for sections/groups

@nolannbiron nolannbiron merged commit b49caaf into main Dec 1, 2025
19 of 20 checks passed
@nolannbiron nolannbiron deleted the nolann/handle-hidden-sections branch December 1, 2025 13:48
clairechabas added a commit that referenced this pull request Dec 3, 2025
…ption

* main: (45 commits)
  Remove corner radius of hint block with heading (#3839)
  Make semantic text colors more vibrant (#3838)
  Fix hidden section not found (#3836)
  Update AIChat context card open delay (#3834)
  Support for hidden sections (#3831)
  Make annotations visible on hover, fix accessibility and outro animations (#3822)
  Replace AI Chat generated content in e2e (#3833)
  Remove sticky prop on Updates block (#3832)
  Stop filtering by language when site space language is unspecified (#3825)
  Fix flaky tests in AI Chat greeting (#3828)
  Add RSS feed for pages with update blocks (#3824)
  Prevent flaky tests in AI Chat followup suggestions (#3827)
  Update wranglerVersion to 4.43.0 (#3826)
  Update Assistant e2e tests (#3814)
  Update Assistant styling (#3797)
  Add `x-gitbook-prefix` and `x-gitbook-token-placeholder` for OpenAPI security scheme (#3820)
  Add 'use server' directive to markdown renderer (#3815)
  Improve OpenAPI circular references (#3821)
  Fix links to other spaces in embeddable view (#3819)
  Optimise page outline (#3813)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants