fix!: move TransportWithoutIO::request() method to I/O-specific traits #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Oct 26, 2025
There was a problem hiding this comment.
That's a great catch, thanks a lot!
To me it seems that the now removed conditional compilation in gix-transport/src/client/traits.rs were a clear indication that something is wrong that needs fixing. I also don't recall why I would have thought this was necessary in the first place, so let's just roll with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RequestWritertype is specific to the I/O mode, so this should not live in the I/O-generic trait.