Skip to content

Refactoring #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

Refactoring #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions src/Gml.Core/Core/Helpers/Launcher/LauncherProcedures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,32 +91,18 @@ public async Task<string> CreateVersion(IVersionFile version, ILauncherBuild lau

if (executeFile != null)
{
localVersion!.Guid = await _files.LoadFile(File.OpenRead(executeFile.FullName),
Path.Combine("launcher", osName, osArch), $"{versionInfo.Name}-{executeFile.Name}");
await using var stream = File.OpenRead(executeFile.FullName);
localVersion!.Guid = await _files.LoadFile(
stream,
Path.Combine("launcher", osName, osArch),
$"{versionInfo.Name}-{executeFile.Name}");
}

_launcherInfo.ActualLauncherVersion[versionInfo.Name] = localVersion;
await _storage.SetAsync(StorageConstants.ActualVersion, version.Version);
await _storage.SetAsync(StorageConstants.ActualVersionInfo, _launcherInfo.ActualLauncherVersion);
}

Console.WriteLine();

// if (version.File is null)
// {
// throw new ArgumentNullException(nameof(version.File));
// }
//
// version.Guid = await _files.LoadFile(version.File, "launcher");
//
// _launcherInfo.ActualLauncherVersion[osTypeEnum] = version;
//
// await _storage.SetAsync(StorageConstants.ActualVersion, version.Guid);
// await _storage.SetAsync(StorageConstants.ActualVersionInfo, _launcherInfo.ActualLauncherVersion);
//
// await version.File.DisposeAsync();
// version.File = null;

return version.Guid;
}

Expand Down