Added https support #9

mwojtyczka · 2019-01-25T11:36:18Z

I added https support for the proxy. I used the proxy in my project but to make it really useful I had to add HTTPS. When using it over HTTP the jwt token can easily be compromised. I updated the documentation accordingly. I did not update the docker files though but that can be easily done (I guess by adding separate docker files for the https or by parametrization).

sokil · 2019-01-25T12:15:43Z

Thank you for contributing.

Currently i expect that this proxy will be behind nginx, where you may configure balancing througn few proxy instance and add https support. Why you can't use nginx?

Update of dockerfiles is not required because any cli parameter may be passed in compose file or in run command:

docker run -p 80:80 gometric/statsd-http-proxy:latest --verbose --tls-cert="..."

JWT token is public information, there are no payload there, and it used just to sign expiration time. Is this really critical?

Will review your code soon.

mwojtyczka · 2019-01-25T12:42:05Z

Thank you! Yes you can certainly pass the docker parameters, just make sure the certificate is somehow provided (by copying to the container or by volume sharing). A description might be sufficient.

For the HTTPS you can certainly place it behing the ngnix but for a simple use cases it is an overkill in my opinion. You can easily support the https with the current libraries without additional complexity. I personally always use https whenever possible. As a rule of thumb I do not want anyone to be able to intercept my communication, no matter what it is.

sokil · 2019-01-26T11:59:24Z

main.go

+	if ( len(*tlsCert) > 0 && len(*tlsKey) > 0) {
+		// start https server
+		err := s.ListenAndServeTLS(*tlsCert, *tlsKey)
+		if err != nil {


err handle may be moved outside if

sokil · 2019-01-26T12:47:02Z

demo/statsdHttpsProxy.sh

@@ -0,0 +1,16 @@
+#!/bin/sh
+
+# This server start listening connections by HTTP and pass it to StatsD by UDP


copy-paste. it's preferred to use one script to start server in different modes. It may ask yser which wariant to start.

Also you specify certificate and key, but they not present.
You may pre-generate it and commit, or to add this files to .gitignore and generate them on first run.

This cli is not friendly

Done, added cert and key generation, as well as ignored them in the .gitignore.

sokil · 2019-01-26T12:48:40Z

demo/index_https.html

+</head>
+<body>
+
+You are running demo of StatsD HTTPS Proxy. Please, start <b>statsdHttpProxy.sh</b> for handling HTTP requests and


copy-paste. maybe better will be to use raddio buttons to select server. And script name statsdHttpProxy.sh is invalid in help message. But i think all server modes must be started from one bash

Added radio button.

sokil · 2019-01-26T12:49:35Z

README.md

+
+```javascript
+$.ajax({
+    url: 'https://127.0.0.1:433/count/some.key.name',


this samples differ only by url. Everyone know what it is https))

removed, merged into the existing index.html

sokil · 2019-01-28T10:57:26Z

.gitignore

+
+# ide files
+.idea/**
+/**/.idea/**


add new line on end of file

ide rules must be in your global gitignore in home dir

sokil · 2019-01-28T10:59:31Z

demo/index.html

 <body>

-You are running demo of StatsD HTTP Proxy. Please, start <b>statsdHttpProxy.sh</b> for handling HTTP requests and
+You are running demo of StatsD HTTP(s) Proxy. Please, start <b>statsdHttp(s)Proxy.sh</b> for handling HTTP(s) requests and


now i can't just copy file from browser and place to console )

sokil · 2019-01-28T11:00:58Z

demo/statsdHttpsProxy.sh

+    --statsd-host=127.0.0.1 \
+    --statsd-port=8125 \
+    --jwt-secret=somesecret \
+    --metric-prefix=prefix.subprefix


sokil · 2019-01-28T11:01:14Z

demo/statsdHttpsProxy.sh

+# This server start listening connections by HTTPS and pass it to StatsD by UDP
+
+# generate self-signed cert and key with default subject
+#openssl req -x509 -nodes -days 358000 -newkey rsa:2048 -keyout key.pem -out cert.pem -subj "/C=PL/ST=test/L=test/O=test/OU=test/CN=test"


you may cehck if file not found and generate in automatically

Corrected. Generating the credentials only if they do not exist.

sokil · 2019-01-28T11:01:35Z

main.go

 	}
+
+	if err != nil {
+        log.Fatal(err)


i think there must be some tabs instead of spaces. run go fmt

sokil · 2019-01-28T11:01:43Z

main.go

 		BuildDate,
 	)
-}
+}


sokil · 2019-01-28T11:07:22Z

README.md

+	--verbose \
+	--http-host=127.0.0.1 \
+	--http-port=433 \
+    --tls-cert=cert.pem \


My GoLand IDE configured to use tabs instead of spaces for indentation due to:

Indentation We use tabs for indentation and gofmt emits them by default. Use spaces only if you must.

You are using spaces)

sokil · 2019-01-28T12:05:42Z

.gitignore

 .glide/
+
+# keys
+*.pem


pem ignored in all project or just in demo dir?

I would generally exlude pem files from the whole project. They should never be checked in. For demo it will be generated on the fly.

sokil · 2019-01-29T20:47:48Z

Merged in https://github.com/GoMetric/statsd-http-proxy/releases/tag/0.9.0.

Thank you for your work

Added https support

bec1bf5

sokil requested changes Jan 26, 2019

View reviewed changes

Implemented code review feedback

83d5f17

sokil requested changes Jan 28, 2019

View reviewed changes

Implemented second code review feedback.

defd2fa

sokil approved these changes Jan 29, 2019

View reviewed changes

sokil merged commit d73aff2 into GoMetric:master Jan 29, 2019

		@@ -0,0 +1,16 @@
		#!/bin/sh

		# This server start listening connections by HTTP and pass it to StatsD by UDP

               .glide/
+              # keys
+              *.pem

Added https support #9

Added https support #9

Uh oh!

Conversation

mwojtyczka commented Jan 25, 2019

Uh oh!

sokil commented Jan 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwojtyczka commented Jan 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokil Jan 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokil Jan 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokil Jan 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokil Jan 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwojtyczka Jan 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokil commented Jan 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sokil commented Jan 25, 2019 •

edited

Loading

sokil Jan 28, 2019 •

edited

Loading

sokil Jan 28, 2019 •

edited

Loading

sokil Jan 28, 2019 •

edited

Loading

sokil Jan 28, 2019 •

edited

Loading

mwojtyczka Jan 29, 2019 •

edited

Loading

sokil commented Jan 29, 2019 •

edited

Loading