Ubuntu requirements and detailed vagrant install#133
Merged
obilodeau merged 1 commit intoGoSecure:masterfrom Oct 18, 2019
ProloG-Shaman:patch-1
Merged
Ubuntu requirements and detailed vagrant install#133obilodeau merged 1 commit intoGoSecure:masterfrom ProloG-Shaman:patch-1
obilodeau merged 1 commit intoGoSecure:masterfrom
ProloG-Shaman:patch-1
Conversation
Contributor
Author
|
I only tested vagrant on Ubuntu, but I assume it is preferable to avoid downloading it from the distribution package managers for other distributions as well. Feel free to change it so that only Ubuntu users should download vagrant from the website, if you think it might cause issues for other distributions. |
Svieg
requested changes
Oct 13, 2019
Collaborator
|
LGTM |
Svieg
approved these changes
Oct 14, 2019
obilodeau
approved these changes
Oct 18, 2019
Contributor
obilodeau
left a comment
obilodeau
left a comment
There was a problem hiding this comment.
You could have kept Debian and Ubuntu in sync and labeled it === Debian / Ubuntu but it doesn't really matter much.
👍
Note to self: we should remove references to packer-io in code and in the readme since Arch's packer-io package was renamed (thx to @Svieg for pointing that out)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added install notes for Ubuntu, specifically so that people do not install vagrant using the package manager. It causes issues when running malboxes.