-
Notifications
You must be signed in to change notification settings - Fork 43
use rich_print
when in-editor
#562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
impl. the usage of these into ModLoaderLog
Scratch all that, just now seeing |
now accepts a Color over a String
being a debug log it felt weird to have color
I'm going to argue, no. Debug logs are, well debug. Color and boldness draws attention. It's common practice to reserve color for status', warnings, or errors. Giving debug logs a color elevates them visually to the same importance, which for me breaks the mental model. Where you can just filter the logs for your mods debug messages, I find personally that keeping debug unbold is the way to go. For reference this is what bold debugs look like Original colored log screenshot in this PR
Never noticed that, but you're right, let me make that change |
this removes the duplicate "ERROR: ERROR" at the start of error logs
Agree with you there. Let's make bold the default option for debug logs with an optional toggle. I'll make the changes once I get home |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some small nitpicks, looks very nice, ty👍
I'll write a follow up PR which addresses the suggested changes |
* style: clean nit picks from #562 * bug: fix editor feature check doesn't error when ModLoaderStore isn't initialized * bug: remove usage of deleted function `is_version_below` * chore: simplify editor check in `_print_rich` * chore: commit KANAjetzt's suggestion Co-authored-by: KANAjetzt <41547570+KANAjetzt@users.noreply.github.com> --------- Co-authored-by: KANAjetzt <41547570+KANAjetzt@users.noreply.github.com>
Allows for a much cleaner separation of the logs. This PR introduces scaffolding for the options profile. Similar to how
hint_color
currently is. Works towards #450