Skip to content

Conversation

@BearDooks
Copy link
Member

@BearDooks BearDooks commented Mar 29, 2021

This PR will change the following

  • Break out the errors in Firestore tasks to a per task error
  • Change the firestore.gd file to accept the different signals from the task errors
  • Remove null from the delete document function since it was throwing a random error
  • Remove the requirements for a type of data in the error code in firestore_collection

The idea is that breaking out the signals and functions will allow us to have better control over the data that is sent and not try to force it into a single function. This PR has been built so that the end user should not have to update their code at all, but the behind the scenes functions work better.

This PR will close the following:
close #166

@BearDooks BearDooks added the priority:2 Critic, to complete as soon as possible. Completion will affect main functionalities. label Mar 29, 2021
@BearDooks
Copy link
Member Author

BearDooks commented Mar 29, 2021

Firestore tester results:

Login with email and password has worked

STARTING FIRESTORE TESTS

Connecting to collection 'Firebasetester'
Trying to get 'Document1
Document got successfully
Trying to print contents of Document1
doc_name: Document1,
doc_fields: {name:Document1},
create_time: 2021-02-27T18:55:18.523129Z

Trying to add a document
Document added successfully
Trying to get 'Document2
Document got successfully
Trying to print contents of Document2
doc_name: Document2,
doc_fields: {active:true, name:Document2},
create_time: 2021-03-29T15:28:21.812096Z

Trying to update Document2
Document Updated successfully
Trying to get 'Document2
Document got successfully
Trying to print contents of Document2
doc_name: Document2,
doc_fields: {active:true, name:Document2, updated:true},
create_time: 2021-03-29T15:28:21.812096Z

Trying to delete Doucment2
Document deleted successfully

Running Firestore Query
[{document:{createTime:2021-02-27T19:52:08.718724Z, fields:{points:{integerValue:10}}, name:projects/roundtable-5c241/databases/(default)/documents/Firebasetester/QueryDoc2, updateTime:2021-02-27T19:59:12.261640Z}, readTime:2021-03-29T15:28:23.583433Z}, {document:{createTime:2021-02-27T19:52:17.602644Z, fields:{points:{integerValue:6}}, name:projects/roundtable-5c241/databases/(default)/documents/Firebasetester/QueryDoc3, updateTime:2021-02-27T19:59:17.958287Z}, readTime:2021-03-29T15:28:23.583433Z}]

FINISHED FIRESTORE TESTS

No error is the debugger inside of Godot

@WolfgangSenff WolfgangSenff merged commit 755875a into main Apr 1, 2021
@WolfgangSenff WolfgangSenff deleted the firestore-cleanup-signals branch April 1, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:2 Critic, to complete as soon as possible. Completion will affect main functionalities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With latest, seems like the recent fix for Firestore documents broke something else.

3 participants