Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TTFBAttribution fields from *Time to *Duration #453

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

philipwalton
Copy link
Member

This PR continues the renaming work from #450 and updates the TTFBAttribution interface with the same changes—all properties whose name ended in *Time have been renamed to *Duration, in order to make it more clear that these are durations of time rather than timestamps.

interface TTFBAttribution {
-  waitingTime: number;
+  waitingDuration: number;

-  dnsTime: number;
+  dnsDuration: number;

-  connectionTime: number;
+  connectionDuration: number;

-  requestTime: number;
+  requestDuration: number;
}

⚠️ Important: this is a breaking change for anyone using the attribution build.

@philipwalton philipwalton changed the title Rename TTFBAttribution fields from *Time to *Duration Rename TTFBAttribution fields from *Time to *Duration Mar 31, 2024
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good but can we update README and CHANGELOG?

Would also be nice to add redirect time as per #395

@philipwalton
Copy link
Member Author

Change itself looks good but can we update README and CHANGELOG?

Doh! Not sure how I forgot to update the README. Updated!

BTW, I've generally only been updated the CHANGELOG before doing a release, but I plan to do that as soon as these changes are in.

Would also be nice to add redirect time as per #395

Yeah, I'm open to that, but I think it'd be worth discussing (and also doing as a separate PR).

src/types/ttfb.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
@philipwalton philipwalton merged commit 372598a into v4 Apr 1, 2024
2 checks passed
@philipwalton philipwalton deleted the ttfb-attribution branch April 1, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants