This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Backport recent DisplayData changes #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @bjchambers Nothing interesting here, pure backport. |
|
R: @bjchambers |
swegner
force-pushed
the
backport
branch
7 times, most recently
from
a84276c to
3cdc92f
Compare
|
I see a build/test failure: Failed tests: |
Looks like there had been some BigQueryIO work that isn't backported which broke the tests for primitive display data. I've manually updated the code. This now has all DisplayData backports in it. PTAL @bjchambers |
This was referenced May 16, 2016
… usage (cherry picked from commit 582befd)
…tadata' (cherry picked from commit 9d45a4a)
…ent super implementation is a no-op, but this is the recommended way to implement the pattern (cherry picked from commit c6690c1)
Introduce `DisplayData#Item` which represents a single item of `DisplayData`. Reduce the number of methods on `DisplayData#Builder` to just deal with adding items, rather than needing per-type overrides. Update all providers of `DisplayData` to use the new API. (cherry picked from commit 47c7abc)
- Refactor Combine display data to not use ClassForDisplay - Refactor DoFnReflector.SimpleDoFnAdapter to not use display data namespace override - Add test case for display data multi-level namespace overrides (cherry picked from commit 5eafdee)
DisplayDataEvaluator is useful for validating how PTransform display data is surfaced in the context of a Pipeline and runner. (cherry picked from commit c4b4180)
(cherry picked from commit 9f6c27c)
(cherry picked from commit 0dab643)
(cherry picked from commit 43085f7)
(cherry picked from commit 007526f)
(cherry picked from commit ea8019e)
(cherry picked from commit d9355c2)
(cherry picked from commit 489298f)
Display data is collected from PTransforms at Pipeline construction time. Collecting display data runs user code from provided transforms and fn's. These components should be designed not to throw during pipeline construction, however we also shouldn't fail a pipeline if this code does fail. This PR adds resiliency to the DataflowPipelineTranslator, where we collect display data for the Dataflow runner, and also a RunnableOnService test to verify that all runners are resilient to display data failures. Other runners are not yet using display data, but will get this validation for free when they do. (cherry picked from commit 58fa155)
(cherry picked from commit 66a5d0d)
(cherry picked from commit 6269b8f)
(cherry picked from commit 62f05d8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.