This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Create the temp dataset in the same location as the queried table in BigQueryTableRowIterator #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peihe
force-pushed
the
fix-405
branch
3 times, most recently
from
efb300f to
3631213
Compare
…BigQueryTableRowIterator
|
R: @dhalperi |
| } catch (IOException e) { | ||
| LOG.error(String.format(error, errorArgs), e.getMessage()); | ||
| String errorMessage = error + String.format(" Cause: %s", e.getMessage()); | ||
| LOG.error(errorMessage); |
There was a problem hiding this comment.
why is this not just LOG.error("{}", error, e);
There was a problem hiding this comment.
done
I want to build the error message once and use in logging and exception.
|
PTAL |
| throw e; | ||
| String errorMessage = String.format( | ||
| "%s. Failing to execute job after %d attempts.", error, MAX_RETRIES + 1); | ||
| LOG.error(errorMessage); |
There was a problem hiding this comment.
done
and, I think it probably will fix the failed tests.
|
This was referenced Sep 6, 2016
dhalperi
added a commit
that referenced
this pull request
Sep 7, 2016
) * BigQueryTableRowIterator: support queries that reference no tables The new code in #411 did not adequately handle the case in which a query does not reference any tables, which could result in a NullPointerException. * fixup! BigQueryTableRowIterator: support queries that refernece no tables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #405