-
Notifications
You must be signed in to change notification settings - Fork 79
docs: CLI instructions #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: CLI instructions #1712
Conversation
boms/cloud-oss-bom/RELEASING.md
Outdated
|
|
||
| ## Prerequisites | ||
|
|
||
| (Does not need to be repeated for each release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (Does not need to be repeated for each release. | |
| (Does not need to be repeated for each release.) |
boms/cloud-oss-bom/RELEASING.md
Outdated
| Install the [`gh`](https://github.com/cli/cli) | ||
| tool if you not previously done so. | ||
|
|
||
| Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. Do not use a laptop or personal machine as the release requires google3 access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is long. Can you break it into two lines?
(Yes, I have a CloudTop.)
| ``` | ||
|
|
||
| ### Build the release binary with Rapid (Legacy web UI) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Check the progress of the Rapid workflow in [Cloud Java Tools Cloud Opensource BOM Kokoro Release](https://...) |
| $ blaze run java/com/google/cloud/java/tools:ReleaseBom -- --version=<release version> | ||
| ``` | ||
|
|
||
| ### Build the release binary with Rapid (Legacy web UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Build the release binary with Rapid (Legacy web UI) | |
| ### Check the release status in Rapid web UI |
I was thinking to suggest removing this section but we still need to check the web UI to see the progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need to check the UI. I need to figure out how the script can query the status to warn the user if something goes wrong. At that point it can provide a link to Rapid or the logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At that point it can provide a link to Rapid or the logs.
That would be nice.
| * Install the [`gh`](https://github.com/cli/cli) | ||
| tool if you not previously done so. | ||
|
|
||
| * Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. Do not use a laptop or personal machine as the release requires google3 access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. Do not use a laptop or personal machine as the release requires google3 access. | |
| * Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. | |
| Do not use a laptop or personal machine as the release requires google3 access. |
| $ blaze run java/com/google/cloud/java/tools:ReleaseBom -- --version=<release version> | ||
| ``` | ||
|
|
||
| ### Build the release binary with Rapid (Legacy web UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At that point it can provide a link to Rapid or the logs.
That would be nice.
@suztomo