Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Oct 16, 2020

@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@elharo elharo requested a review from suztomo October 16, 2020 16:43

## Prerequisites

(Does not need to be repeated for each release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(Does not need to be repeated for each release.
(Does not need to be repeated for each release.)

Install the [`gh`](https://github.com/cli/cli)
tool if you not previously done so.

Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. Do not use a laptop or personal machine as the release requires google3 access.
Copy link
Contributor

@suztomo suztomo Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is long. Can you break it into two lines?

(Yes, I have a CloudTop.)

```

### Build the release binary with Rapid (Legacy web UI)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Check the progress of the Rapid workflow in [Cloud Java Tools Cloud Opensource BOM Kokoro Release](https://...)

$ blaze run java/com/google/cloud/java/tools:ReleaseBom -- --version=<release version>
```

### Build the release binary with Rapid (Legacy web UI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Build the release binary with Rapid (Legacy web UI)
### Check the release status in Rapid web UI

I was thinking to suggest removing this section but we still need to check the web UI to see the progress.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to check the UI. I need to figure out how the script can query the status to warn the user if something goes wrong. At that point it can provide a link to Rapid or the logs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that point it can provide a link to Rapid or the logs.

That would be nice.

* Install the [`gh`](https://github.com/cli/cli)
tool if you not previously done so.

* Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. Do not use a laptop or personal machine as the release requires google3 access.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop. Do not use a laptop or personal machine as the release requires google3 access.
* Clone this repository onto your corp desktop, Ubiquity instance, or CloudTop.
Do not use a laptop or personal machine as the release requires google3 access.

$ blaze run java/com/google/cloud/java/tools:ReleaseBom -- --version=<release version>
```

### Build the release binary with Rapid (Legacy web UI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that point it can provide a link to Rapid or the logs.

That would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants