feat: add cloud-build job for the release process GH-66 #108
Conversation
hessjcg
force-pushed
the
release-jobs
branch
from
f66d084 to
2d23489
Compare
hessjcg
changed the title
| @@ -0,0 +1,34 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
nit: should the file just be called "release.sh"?
There was a problem hiding this comment.
It only publishes the installer, it doesn't do the whole release. So I called it "publish-installer.sh". The main release file is .build/release.yaml.
tools/publish-installer.sh
Outdated
| fi | ||
|
|
||
| # Upload the installer files to the storage bucket | ||
| gcloud storage --project cloud-sql-connectors cp installer/install.sh "gs://cloud-sql-connectors/cloud-sql-proxy-operator-dev/${VERSION}/install.sh" |
There was a problem hiding this comment.
nit: can we make this project and bucket as variables (so they are easier to change in 1 place later)?
tools/publish-installer.sh
Outdated
| fi | ||
|
|
||
| # Upload the installer files to the storage bucket | ||
| gcloud storage --project cloud-sql-connectors cp installer/install.sh "gs://cloud-sql-connectors/cloud-sql-proxy-operator-dev/${VERSION}/install.sh" |
There was a problem hiding this comment.
Cloud Build has a built in mechanism for pushing files when the job is complete. Would it be better to just inline these steps using that mechanism? https://cloud.google.com/build/docs/building/store-artifacts-in-cloud-storage#store-artifact-storage
There was a problem hiding this comment.
Unfortunately, this doesn't give us enough flexibility with the filenames. I think the script will have to do.
3 participants
Fixes #<issue_number_goes_here>