feat: Add a release job to generate code on release PRs GH-66 #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
added
the
generate: run
hessjcg
force-pushed
the
release-please-cleanup
branch
from
c98a07b to
1567bcb
Compare
hessjcg
removed
the
generate: run
hessjcg
changed the title
hessjcg
force-pushed
the
release-please-cleanup
branch
from
229ee18 to
2ad85dc
Compare
hessjcg
force-pushed
the
release-please-cleanup
branch
from
f1752f4 to
05356de
Compare
| echo "Generate did not cause any changes to the code. OK to proceed with the release" | ||
| else | ||
| echo "Generate updated the code. Committing the changes..." | ||
| git config --global user.email "$GITHUB_ACTOR@users.noreply.github.com" |
Collaborator
There was a problem hiding this comment.
is this safe? Would this be an unverified commit?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure what kind of commit it would be. I think it is verified. The github action takes on the permissions of the actor that initiated that action.
jackwotherspoon
approved these changes
Nov 17, 2022
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
LGTM, however I think we should maybe double-check with the Github Automation team before merging if they have a best practice for pushing code from a Github Action as well as if there is any known issues with doing so from the release-please app's bot user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After release-please opens a PR, generate the code so that the final release version stored in version.txt
is properly reflected in the generated code.