feat: PodSpec changes now are applied only to pods on creation (#41 step 7) #118
Conversation
hessjcg
changed the title
hessjcg
force-pushed
the
reconcile-podtemplate-updates
branch
from
975ee9b to
015e334
Compare
hessjcg
force-pushed
the
reconcile-podtemplate-updates
branch
9 times, most recently
from
77cbf0b to
7cf47c4
Compare
hessjcg
force-pushed
the
reconcile-controller-updates
branch
from
b9d6eb1 to
309d711
Compare
hessjcg
force-pushed
the
reconcile-podtemplate-updates
branch
18 times, most recently
from
6916456 to
ab25dd5
Compare
|
|
||
| } | ||
|
|
||
| func TestProperCleanupOfEnvAndVolumes(t *testing.T) { |
There was a problem hiding this comment.
We don't remove the a configuration from a PodTemplateSpec after it has been applied anymore.
| u = workload.NewUpdater() | ||
| ) | ||
|
|
||
| // Create a deployment |
There was a problem hiding this comment.
Most of the changes in this test simply replace Deployment with Pod.
| wantsInstanceArg, foundContainer.Args) | ||
| } | ||
|
|
||
| // Now change the spec |
There was a problem hiding this comment.
No need to test applying the configuration to the PodSpec a second time with a slight change.
| }) | ||
| } | ||
|
|
||
| // loadOldEnvVarState loads the state connecting EnvVar changes done by the |
There was a problem hiding this comment.
Remove code that saves the the existing state so changes can later be removed.
| inst := matches[i] | ||
| var instContainer *corev1.Container | ||
|
|
||
| for j := range containers { |
There was a problem hiding this comment.
At the beginning of this function all containers on PodSpec were defined in the workload by the user. No more need to distinguish between containers that existed in the original workload and containers added by the operator.
…es PodSpec update code.
hessjcg
force-pushed
the
reconcile-podtemplate-updates
branch
from
5f0429a to
71493f9
Compare
| for i := 0; i < len(proxies); i++ { | ||
| l.Items[i] = *proxies[i] | ||
| } | ||
| _, _, err := u.ConfigurePodProxies(l, wl, nil) |
There was a problem hiding this comment.
This is the only place ConfigurePodProxies is called. Should we get rid of the unused return values from the signature?
There was a problem hiding this comment.
The return values are used in mainline code coming in the next PR.
// internal/controller/pod_controller.go:88
// Reconfigure the PodSpec
updated, matchingInstances, wlConfigErr = a.updater.ConfigurePodProxies(instList, wl, owners)
Sadly, that means we need this awkward conversion method in the test code.
2 participants
The proxy configuration is now only applied when a pod is created. The old algorithm allowed updates to the PodSpec
to apply changes after the pod was created. This PR simplifies the logic that applies the proxy configuration to a
PodSpec, mainly removing the code that would update the pod spec multiple times.