feat: Updating the RolloutStrategy field is not allowed.#212
Merged
Conversation
enocom
reviewed
Feb 22, 2023
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
PR looks good functionally, but the tests are a bit hard to read.
| }, | ||
| }, | ||
| AuthProxyContainer: &cloudsqlapi.AuthProxyContainerSpec{ | ||
| RolloutStrategy: "Workload", |
Member
There was a problem hiding this comment.
This line is the key line right? The strategy is workload before, and not changed after?
Could we make that change more clear and hide the rest of these details?
Cf. https://arslan.io/2022/12/04/functional-table-driven-tests-in-go/
Member
There was a problem hiding this comment.
Should we pull workload rollout strategy updates into a separate test?
Collaborator
Author
There was a problem hiding this comment.
I moved RolloutStrategy update table tests into their own test function.
| return allErrs | ||
| } | ||
|
|
||
| func validateRolloutStrategyChange(c *AuthProxyContainerSpec, oc *AuthProxyContainerSpec) []*field.Error { |
Member
There was a problem hiding this comment.
Let's add a doc string here explaining why this is important and what validate is doing.
hessjcg
force-pushed
the
gh-36-rolloutstrategy
branch
from
85e9f6e to
72c429c
Compare
enocom
approved these changes
Feb 23, 2023
| RolloutStrategy: "None", | ||
| }, | ||
| oldSpec: &cloudsqlapi.AuthProxyContainerSpec{ | ||
| RolloutStrategy: "Workload", |
This was referenced Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RolloutStrategy controls when and how changes to the AuthProxyWorkload are rolled out to
running workloads. Changing this value after creation would cause an inconsistent rollout state.
Related to #36