feat: add webhook and test to see that it updates a new workload #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
requested changes
Oct 3, 2022
shubha-rajan
approved these changes
Oct 3, 2022
enocom
approved these changes
Oct 3, 2022
| // WorkloadAdmissionWebhook implementation of a controller-runtime webhook for all | ||
| // supported workload types: Deployment, DaemonSet, StatefulSet, Pod, CronJob, Job | ||
| type WorkloadAdmissionWebhook struct { | ||
| Client client.Client |
Collaborator
Author
There was a problem hiding this comment.
client.Client is an interface.
This is one of the weird things about Go is that interfaces could be implemented by pointers or values. Nobody uses a naming convention to indicate what is an interface and what is concrete type. The only syntax that indicates that something is concrete is accessing fields directly.
This was referenced Oct 12, 2022
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the mutating webhook that will update workloads as they are created or modified.
config/**/*.yaml changes are all boilerplate or generated changes to enable the webhook controller.