fix: preserve multi-dialect golden_sql for BIRD#262
Merged
IsmailMehdi merged 3 commits intoGoogleCloudPlatform:mainfrom Mar 18, 2026
Merged
fix: preserve multi-dialect golden_sql for BIRD#262IsmailMehdi merged 3 commits intoGoogleCloudPlatform:mainfrom
IsmailMehdi merged 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Update `load_dataset_from_bird_format` to pass the `golden_sql` dictionary directly to `EvalInputRequest` instead of hardcoding to the first configured dialect. This enables true multi-engine evaluation on datasets like BIRD where golden SQL differs per dialect. Added fallback logic to map a flat 'SQL' string across all requested dialects if a dictionary isn't available.
IsmailMehdi
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
load_dataset_from_bird_formatto pass thegolden_sqldictionary directly toEvalInputRequestinstead of hardcoding to the first configured dialect.This enables true multi-engine evaluation on datasets like BIRD where golden SQL differs per dialect. Added fallback logic to map a flat 'SQL' string across all requested dialects if a dictionary isn't available. It addresses a regression introduced in one of my previous PRs.