Skip to content

fix: implement timeouts and failure recovery to prevent thread hanging in evaluator#266

Merged
IsmailMehdi merged 4 commits intoGoogleCloudPlatform:mainfrom
aseering:fix-execution-timeouts
Mar 17, 2026
Merged

fix: implement timeouts and failure recovery to prevent thread hanging in evaluator#266
IsmailMehdi merged 4 commits intoGoogleCloudPlatform:mainfrom
aseering:fix-execution-timeouts

Conversation

@aseering
Copy link
Copy Markdown
Contributor

Make the code more defensive against database connection issues, queries that fail in unexpected ways, and other sorts of test-runtime issues.

  • Add timeouts such that tests that run for too long are terminated
  • Add error handling such that exceptions and other errors are consistently treated as query failures, rather than potentially dropping the affected eval (resulting in a run that never reaches 100%)

@aseering aseering force-pushed the fix-execution-timeouts branch 2 times, most recently from 21d4b98 to 9bcb59e Compare March 16, 2026 21:11
IsmailMehdi
IsmailMehdi previously approved these changes Mar 16, 2026
@aseering aseering force-pushed the fix-execution-timeouts branch from f096cb7 to 6b19a48 Compare March 17, 2026 00:42
@IsmailMehdi
Copy link
Copy Markdown
Collaborator

/gcbrun

@IsmailMehdi IsmailMehdi merged commit bb77c2f into GoogleCloudPlatform:main Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants