Skip to content

Conversation

@anguillanneuf
Copy link
Member

@anguillanneuf anguillanneuf commented Sep 13, 2021

The existing typed background function example has two problems:

  1. Classes in the default package cannot be imported by classes in packages. This applies to com.example.PubSubBackground.PubSubMessage.
  2. pubSubMessage.messageId will always return null. Instead, the example should print event ID, which is populated by the message ID.

I published some instructions for testing functions-framework-java with the Pub/Sub emulator in my personal repo. I was hoping to include them here after the next release of the library. See #104.

@matthewrobertson matthewrobertson self-requested a review September 14, 2021 16:13
Copy link
Member

@matthewrobertson matthewrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@matthewrobertson matthewrobertson merged commit b339942 into GoogleCloudPlatform:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants