Skip to content

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Feb 3, 2025

Fixes #673.

/cc @matthewrobertson

@google-cla
Copy link

google-cla bot commented Feb 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@caugner
Copy link
Contributor Author

caugner commented Feb 6, 2025

CLA is sorted out, fwiw.

@robinvw1
Copy link

robinvw1 commented Feb 12, 2025

@matthewrobertson can we have this merged?

Also running in this problem. Both @types/express and express should stay inside the same major version. :)

@chujchen chujchen removed their assignment Mar 19, 2025
@matthewrobertson matthewrobertson merged commit d40a514 into GoogleCloudPlatform:main Mar 27, 2025
38 of 56 checks passed
@matthewrobertson
Copy link
Member

sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3.4.3 upgraded to @types/express:^5.0.0 although express:^4.21.2 is used

4 participants