prepare script does not read env_variables

[pnicorelli]

Hi all,

I'm not sure this issue is ONTOPIC, I just use some code from your example.

I have some issue to get the process.env from a prepare script in package.json.
I'm trying to run mysql migration before starting the app but I can not fetch the process.env variables

My package.json

...
  "scripts": {
     ...
    "prepare": "npm run gcp-build",
    "gcp-build": "node migrations.js",
  },
...

My migrations.js

var path = require('path')
var mysql = require('mysql')
var migration = require('mysql-migrations')

require('dotenv').config()

var connection = mysql.createPool({
  connectionLimit: 10,
  host: process.env.DB_HOST,
  user: process.env.DB_USER,
  password: process.env.DB_PASS,
  database: process.env.DB_NAME
})

migration.init(connection, path.join(__dirname, '/migrations'))

My app read the env_variables from app.yaml without problem but the prepare script do not.

Any help will be appreciated.

[fhinkel]

@pnicorelli Thanks for posting the issue. Could you post your app.yaml as well? I don't see why the script wouldn't pick up the variables when the app can.

[pnicorelli]

Hi @fhinkel, thanks for your reply

app.yaml

runtime: nodejs10
service: xxxxxx-api

includes:
  - env_variables.yaml

env_variables.yaml

env_variables:
  NODE_ENV: "production"
  CLIENT_ID: "xxxxxxxxxxxxxxxxxxxxx.apps.googleusercontent.com"
  CLIENT_SECRET: "xxxxxxxxxxxxxxxxxxxxxxxxx"
  REDIRECT_URL: "https://xxxxxxxxxx.appspot.com"
  DB_USER: "xxxxxx"
  DB_PASS: "xxxxxx"
  DB_NAME: "xxxxxx-db"
  INSTANCE_CONNECTION_NAME: "xxxxxx:europe-west2:xxxxxx-db"

[fhinkel]

Thanks for clarifying. I tried it, looks like the prepare task doesn't pick up env variables in app.yaml. For know, can you restructure your code to use the variables only in the start script? e.g.,

...
  "scripts": {
     ...
    "start": "node migrations.js && node app.js",
  },
...

[pnicorelli]

I came to the same conclusion using this example

Actually I changed the flow: the migration script will run from the CI server I use to deploy the app (It seem to me I can have a better control).

Thank you for your interest
Cheers

[fhinkel]

That's almost the same reproduction that I used 😄

Glad you found a solution. I opened a bug internally to clarify that in our docs, so other people don't run in to the same problem. Thanks again for reporting!

[ahmadnassri]

I finally got my full deploy workflow working and gcp-build was failing to run db migration ... then I found this issue ..

TABLE FLIP!