Skip to content

Conversation

@noerog
Copy link
Contributor

@noerog noerog commented Sep 12, 2024

Description

Fixes b/310269530

Checklist

@noerog noerog requested review from a team as code owners September 12, 2024 01:49
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: healhcare labels Sep 12, 2024
@davidcavazos
Copy link

File "/workspace/healthcare/api-client/v1/fhir/fhir_stores_test.py", line 244, in test_patch_fhir_store
    fhir_stores.patch_fhir_store(project_id, location, dataset_id, fhir_store_id)
TypeError: patch_fhir_store() missing 1 required positional argument: 'pubsub_topic'

Seems like the test needs to be updated.

@noerog noerog force-pushed the hcapi-fhirnotificationconfig branch from 56e42df to fb7c1ce Compare November 13, 2024 13:20
@noerog
Copy link
Contributor Author

noerog commented Nov 13, 2024

File "/workspace/healthcare/api-client/v1/fhir/fhir_stores_test.py", line 244, in test_patch_fhir_store
    fhir_stores.patch_fhir_store(project_id, location, dataset_id, fhir_store_id)
TypeError: patch_fhir_store() missing 1 required positional argument: 'pubsub_topic'

Seems like the test needs to be updated.

My mistake, the topic should be optional. Added a fix but 3.8 and 3.12 builds are still failing, though the test logs are empty. Will wait to see if they build.

@engelke engelke merged commit 3477e6a into GoogleCloudPlatform:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healhcare samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants