Skip to content

fix: set deletion_protection on cloud run #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: set deletion_protection on cloud run #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c080200
fix: update minimum provider version, set deletion_protection on clou…
glasnt Sep 27, 2024
5c91042
bring test provider versions to same minimum version
glasnt Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/apis.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# Google Cloud Services to enable
module "project_services" {
source = "terraform-google-modules/project-factory/google//modules/project_services"
version = "16.0.1"
version = "17.0.0"
disable_services_on_destroy = false
project_id = var.project_id
enable_apis = var.enable_apis
Expand Down
2 changes: 1 addition & 1 deletion infra/examples/simple_example/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 4.0"
version = ">= 6"
}
}
}
2 changes: 2 additions & 0 deletions infra/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ resource "google_cloud_run_v2_service" "default" {
location = var.region
ingress = "INGRESS_TRAFFIC_ALL"

deletion_protection = false

template {
containers {
image = var.initial_run_image
Expand Down
2 changes: 1 addition & 1 deletion infra/test/setup/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

module "project" {
source = "terraform-google-modules/project-factory/google"
version = "~> 16.0"
version = "~> 17.0"

name = "ci-javascript-webapp"
random_project_id = "true"
Expand Down
2 changes: 1 addition & 1 deletion infra/test/setup/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 3.25.0"
version = ">= 6"
}
}
}
4 changes: 2 additions & 2 deletions infra/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 4.83.0, < 7"
version = ">= 6, < 7"
}

google-beta = {
source = "hashicorp/google-beta"
version = ">= 4.83.0, < 7"
version = ">= 6, < 7"
}

time = {
Expand Down