fix: restore missing dependencies #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasnt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #78 is failing.
Logs: after apply, the client website is displaying 404, not the expected placeholder
Diagnosis: the placeholder deployment was failing due to missing
jsonpackage.Cause: the placeholder image was automatically re-built when #58 was merged. Previously it was using a manually-built image that was tagged "latest" that was not the latest version.
jsondependency was removed from the Dockerfile erroneously, and only after updating the image does it present on other deployments.Fix: Having the image built from the same repo as changes that use it means there needs to be a segmented deployment process, where in-flight images can be used, rather than always 'latest'
Temp workaround: once this PR is created, the image will be built with this fix, which will unblock all builds and deployments.
Update: the image was also missing the
envsubstrpackage, which wasn't noticed as there's no current mechanism to test deployments of the placeholder in the same PR the placeholder is being updated