Skip to content

Conversation

@grayside
Copy link
Contributor

This change swaps out the "standard" billing account for a "low reputation" billing account. This is intended to see if our automated testing process can surface more accurate end-to-end error conditions faced by folks using this blueprint in a wider range of circumstances.

Considerations for merge include:

  • Are the error messages sufficiently distinct from other errors we are likely to surface in testing that we can simply switch, rather than establish a "billing account matrix" and test both ways?

@grayside grayside self-assigned this May 18, 2023
@grayside
Copy link
Contributor Author

Lint error is because of temporary change to variable defaults.

@grayside
Copy link
Contributor Author

I think we're good to make this change and observe for a while. I've now limited this to just the billing account and further change exploration will be separate.

@grayside grayside marked this pull request as ready for review May 24, 2023 17:24
@grayside grayside requested review from a team, donmccasland and glasnt as code owners May 24, 2023 17:24
@glasnt
Copy link
Collaborator

glasnt commented Jun 1, 2023

@grayside did you want this one merged, and #79 closed unmerged?

@grayside
Copy link
Contributor Author

grayside commented Jun 1, 2023

Yes, this is one I want merged. #79 is for additional experimentation but I don't have a current next experiment so we can close.

@glasnt
Copy link
Collaborator

glasnt commented Jun 4, 2023

/gcbrun

@glasnt
Copy link
Collaborator

glasnt commented Jun 5, 2023

Glad I merged this second in the queue. There's some interesting errors after merging #58

First error:

suffix-example-apply: Error: "404" is not less than or equal to "299"

DefineApply from tests runs during apply. This came up because the placeholder didn't successfully deploy. We may want to add placeholder job polling like we do on client deploy job polling.

On retry:

suffix-example-apply: Error: Error creating service account: googleapi: Error 429: A quota has been reached for project number NNN: Service accounts created per minute per project.

This is temporal?

@glasnt
Copy link
Collaborator

glasnt commented Jun 5, 2023

/gcbrun

@glasnt
Copy link
Collaborator

glasnt commented Jun 5, 2023

/gcbrun

1 similar comment
@glasnt
Copy link
Collaborator

glasnt commented Jun 5, 2023

/gcbrun

@glasnt
Copy link
Collaborator

glasnt commented Jun 5, 2023

Cause of build errors in #84

API issue looks temporal, not re-created.

@glasnt glasnt merged commit 3fb6326 into main Jun 5, 2023
@glasnt glasnt deleted the testing-low-reputation branch June 5, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants