-
Notifications
You must be signed in to change notification settings - Fork 71
feat: migrate postdeployment to data http #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
grayside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial questions pass, more a part of design exploration than code review.
| gcloud run jobs execute "$SETUP_JOB" --wait --project "$PROJECT_ID" --region "$REGION" | ||
|
|
||
| echo "Running client deploy..." | ||
| gcloud run jobs execute "$CLIENT_JOB" --wait --project "$PROJECT_ID" --region "$REGION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this exit with a non-zero status code on failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it fires https://github.com/GoogleCloudPlatform/avocano/blob/main/client/docker-deploy.sh so in theory yes, if a failed firebase command returns the correct exit code.
|
Closing in favor of #125 |
Replaces compute engine and associated resources with a
data "http"call to the Cloud Run APIRequires moving the logic from the metadata startup scripts to within the containers for placeholder, and a new container for
init. Uses the same permissions, only the service account has renamed to reflect the usage.Merge blocked on:
containers.tfto reference thelatestimages (manually created:postjsscurltagged images used while testing)Lint issues:
Build failures:
data.http.execute_placeholder_job)data.http.execute_init_job)